[ALMIOPEN-1856] Simplify dnn-benchmarking engine comparison CLI#7866
Merged
SamuelReeder merged 6 commits intoJun 1, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7866 +/- ##
===========================================
+ Coverage 62.06% 62.08% +0.02%
===========================================
Files 2085 2087 +2
Lines 357573 357886 +313
Branches 54060 54097 +37
===========================================
+ Hits 221918 222179 +261
- Misses 116866 116894 +28
- Partials 18789 18813 +24
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
reviewed
Jun 1, 2026
tvy-amd
left a comment
Contributor
There was a problem hiding this comment.
I love the output table and the shortness of this PR.
Looks good overall. I just had a couple of suggestions
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
tvy-amd
reviewed
Jun 1, 2026
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the old A/B-specific dnn-benchmarking workflow with an explicit ordered multi-engine path. It keeps engine selection on
--engine, supports repeated engine IDs as distinct selections, and allows comma-delimited plugin paths that map positionally to the selected engines.Risk Assessment
Medium risk. This changes CLI behavior and removes legacy A/B flags in a benchmark tool, but the new path is covered by parser, config, execution, reporting, full Python tests, and gfx90a hardware smoke validation.
Testing Summary
/opt/rocm/lib/hipdnn_plugins/enginesand ran dnn-benchmarking smoke tests for single-engine, two-engine, and comma-delimited plugin-path flows.Testing Checklist
python3 -m compileall -q projects/hipdnn/tools/dnn-benchmarking/src/dnn_benchmarking projects/hipdnn/tools/dnn-benchmarking/tests- Status: Passedpre-commit run --files <PR changed files>- Status: Passedworkspace/scripts/alola-session run -- 'cd /home/AMD/sareeder/worktrees/rocmlibs-benchmarking-alola-test/projects/hipdnn/tools/dnn-benchmarking && source /workspace/.venv/bin/activate && DNN_BENCH_WORKSPACE=/workspace python -m pytest tests'- ASICs: gfx90a - Status: Passed, 683 passed, 6 skipped, 8 xfailedhipdnn_list_engines --plugin-dir /opt/rocm/lib/hipdnn_plugins/engines- ASICs: gfx90a - Status: Passed, foundMIOPEN_ENGINEandMIOPEN_ENGINE_DETERMINISTICpython -m dnn_benchmarking --graph graphs/sample_conv_fwd.json --warmup 1 --iters 2 --engine 1563989756945604898 --plugin-path /opt/rocm/lib/hipdnn_plugins/engines- ASICs: gfx90a - Status: Passedpython -m dnn_benchmarking --graph graphs/sample_conv_fwd.json --warmup 1 --iters 5 --engine 1563989756945604898,-6748551569128940061 --plugin-path /opt/rocm/lib/hipdnn_plugins/engines- ASICs: gfx90a - Status: Passedpython -m dnn_benchmarking --graph graphs/sample_conv_fwd.json --warmup 1 --iters 1 --engine 1563989756945604898,-6748551569128940061 --plugin-path /opt/rocm/lib/hipdnn_plugins/engines,/opt/rocm/lib/hipdnn_plugins/engines- ASICs: gfx90a - Status: PassedExample comparison:
Technical Changes
--AId,--BId,--APath, and--BPathflags.--plugin-pathparsing with validation for one shared plugin path or one path per selected engine.--engineIDs and models each requested run as an ordered engine selection with its own plugin path.hipdnn_list_engines --plugin-dir <path>in CLI help so users can discover engine IDs and names.